Skip to content

Remove unnecessary check of cuSOLVER#2529

Merged
kmaehashi merged 5 commits intocupy:masterfrom
grlee77:remove_cusolver_checks
Oct 18, 2019
Merged

Remove unnecessary check of cuSOLVER#2529
kmaehashi merged 5 commits intocupy:masterfrom
grlee77:remove_cusolver_checks

Conversation

@grlee77
Copy link
Copy Markdown
Member

@grlee77 grlee77 commented Oct 4, 2019

This PR removes some checks that were supporting CUDA Toolkit versions older than 8.0. It seems that older Toolkit versions are no longer supported.

Aside from the checks, the only other change is the second commit which enables a commented-out cusparse.getStream method also requires CUDA Toolkit >=8.0.

@leofang
Copy link
Copy Markdown
Member

leofang commented Oct 6, 2019

How about cupyx/linalg/sparse/solve.py, cupyx/scipy/linalg/decomp_lu.py, and cupyx/scipy/sparse/linalg/solve.py?

kmaehashi
kmaehashi requested changes Oct 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check files pointed by @leofang? They also use cusolver flag.

@kmaehashi kmaehashi added the cat:code-fix Code refactoring that do not change behavior label Oct 7, 2019
@grlee77 grlee77 force-pushed the remove_cusolver_checks branch from a98f132 to 19c1562 Compare October 7, 2019 17:33
@grlee77
Copy link
Copy Markdown
Member Author

grlee77 commented Oct 7, 2019

Thanks @leofang, looks like my grep missed those the first time around. The only remaining instances I see now are the definition of the constants and one test (test_cusolver_enabled).

@kmaehashi
Copy link
Copy Markdown
Member

kmaehashi commented Oct 18, 2019

pfnCI, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Oct 18, 2019

Successfully created a job for commit 6206781:

@kmaehashi kmaehashi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Oct 18, 2019
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Oct 18, 2019

Jenkins CI test (for commit 6206781, target branch master) failed with status FAILURE.

@kmaehashi
Copy link
Copy Markdown
Member

kmaehashi commented Oct 18, 2019

pfnCI, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Oct 18, 2019

Successfully created a job for commit 6206781:

@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Oct 18, 2019

Jenkins CI test (for commit 6206781, target branch master) succeeded!

@kmaehashi kmaehashi merged commit b2404c9 into cupy:master Oct 18, 2019
@kmaehashi kmaehashi added this to the v7.0.0rc1 milestone Oct 18, 2019
@kmaehashi kmaehashi changed the title checks for whether cuSOLVER is enabled aren't needed anymore Remove unnecessary check of cuSOLVER Oct 18, 2019
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Oct 18, 2019

Jenkins CI test (for commit 6206781, target branch master) succeeded!

@hvy hvy mentioned this pull request Oct 18, 2019
Merged
@grlee77 grlee77 deleted the remove_cusolver_checks branch November 26, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmaehashi kmaehashi kmaehashi requested changes

Assignees

@kmaehashi kmaehashi

Labels

cat:code-fix Code refactoring that do not change behavior st:test-and-merge (deprecated) Ready to merge after test pass.

Projects

None yet

Milestone

v7.0.0rc1

Development

Successfully merging this pull request may close these issues.

5 participants

@grlee77 @leofang @kmaehashi @pfn-ci-bot @chainer-ci