Skip to content

Allow to use real and imag on cuda kernels#2520

Merged
asi1024 merged 1 commit intocupy:masterfrom
emcastillo:complex_real_imag
Oct 16, 2019
Merged

Allow to use real and imag on cuda kernels#2520
asi1024 merged 1 commit intocupy:masterfrom
emcastillo:complex_real_imag

Conversation

@emcastillo
Copy link
Copy Markdown
Member

ReductionKernel, ElementwiseKernel and RawKernel couldn't use real(number) or img(number) to retrieve the real and imaginary parts of complex numbers

@leofang
Copy link
Copy Markdown
Member

leofang commented Oct 3, 2019

@emcastillo Since you mentioned RawKernel, could you help get #1866 merged or take it over? It is hard for new users to learn using complex numbers in RawKernel without a proper documentation.

@asi1024 asi1024 added the cat:enhancement Improvements to existing features label Oct 9, 2019
@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Oct 9, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 0858efb:

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 0858efb, target branch master) failed with status FAILURE.

@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Oct 16, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 0858efb:

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 0858efb, target branch master) succeeded!

@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Oct 16, 2019

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:enhancement Improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants