Closed
Conversation
Member
|
Thanks @leofang! Will take a look. |
Member
Author
|
Please block this PR by #1941. If the backend is changeable, |
|
Can I take up on this issue |
Merged
Member
Author
|
This PR is superseded by #2389. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1657, a
.compile()method is desired. I implemented it and added two tests.A few words on this implementation: while it functions as requested, upon reflection I feel the
compile()method should belong to the module level instead of theRawKernelclass. The later implies that a CUDA kernel, instead of a module, is returned and used. However, I don't see any other way to do so without breaking backward compatibility, so this is a design choice I leave for you to worry in the future. Should you have any comments or suggestions, I'm more than happy to discuss and make changes.Thanks.