Implement __array_function__ interface#1650
Merged
takagi merged 2 commits intocupy:masterfrom Jan 8, 2019
Merged
Conversation
hameerabbasi
left a comment
There was a problem hiding this comment.
Just a small bug in your implementation.
Member
Author
|
@hameerabbasi I want to try with NumPy. Do you have an implementation of NEP 18? |
|
We don't have any implementation of NEP 18 yet, beyond the proof of concept implementation referenced in the NEP (which doesn't actually implement the NumPy API). |
Member
Author
|
OK, I am waiting it. |
Member
Author
|
Please read numpy/numpy#12028. |
|
The development branch of numpy now has support for |
Member
Author
|
Thanks, I will try it. |
Member
Author
|
This PR is working with NumPy master branch. @shoyer |
8ffa4cd to
7634174
Compare
Contributor
|
LGTM! I suppose that it is reasonable to merge this feature soon as |
This was referenced Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1322
Please see discussion
numpy/numpy#11129numpy/numpy#12028.