Merged
Conversation
unnonouno
suggested changes
May 31, 2018
|
|
||
| try: | ||
| postargs = ['/MANIFEST'] if sys.platform == 'win32' else [] | ||
| compiler.link_executable(objects, |
Contributor
There was a problem hiding this comment.
build_and_run calls link_executable, but build_shlib calls link_shared_lib . You cannot change it.
Member
Author
|
I fixed. |
Contributor
|
LGTM |
Contributor
|
Do we need to backport it? |
Member
|
@unnonouno This pull-request is marked as |
Member
Author
|
No. I removed to-be-backported label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to #1117.