fixed a bug where the attachments are extracted from the context too early, this prevented AfterStep from making attachments #637
Merged
Johnlon merged 13 commits intocucumber:mainfrom Jul 23, 2024
portingle:main
Merged
fixed a bug where the attachments are extracted from the context too early, this prevented AfterStep from making attachments #637Johnlon merged 13 commits intocucumber:mainfrom portingle:main
Johnlon merged 13 commits intocucumber:mainfrom
portingle:main
Conversation
…t yet recorded in the reports as 'Ambiguous', and no test cases figured out yet
… take a look at how cuke jvm report ambiguous steps and sets the step status to 'ambiguous' rather than my current solution which just blows the test up as a regular step error
…us to make cucumber jvm'
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
…early, this prevented AfterStep from making attachments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
fixed a bug where the attachments are extracted from the context too early, this prevented AfterStep from making attachments
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.