ambiguous step def detection akin to cucumber jvm#636
Merged
Johnlon merged 11 commits intocucumber:mainfrom Jul 1, 2024
portingle:main
Merged
ambiguous step def detection akin to cucumber jvm#636Johnlon merged 11 commits intocucumber:mainfrom portingle:main
Johnlon merged 11 commits intocucumber:mainfrom
portingle:main
Conversation
…t yet recorded in the reports as 'Ambiguous', and no test cases figured out yet
… take a look at how cuke jvm report ambiguous steps and sets the step status to 'ambiguous' rather than my current solution which just blows the test up as a regular step error
…us to make cucumber jvm'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
- Coverage 83.21% 80.27% -2.94%
==========================================
Files 28 40 +12
Lines 3413 3149 -264
==========================================
- Hits 2840 2528 -312
- Misses 458 502 +44
- Partials 115 119 +4 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Is there any documentaton for godog to update on this change? |
Member
Author
|
BTW the coverage results seem quite bogus to me - same on the last PR I made. It reports low coverage on commits from previous work not part of this change. |
vearutop
reviewed
Jul 1, 2024
vearutop
approved these changes
Jul 1, 2024
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #635
🤔 What's changed?
As discussed on related issue this change adds a behaviour under 'strict' mode to detect ambiguous step definitions.
As per cuke jvm this change also adds the "ambiguous" status to godog which appears in the relevant reports; pretty/json.
⚡️ What's your motivation?
Detection of ambiguous steps is a feature of cucumber and behave but missing from godog.
🏷️ What kind of change is this?
This change is only affective under strict mode.
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.