Additional code review observations on Attach() functionality from https://github.com/cucumber/godog/pull/623#628
Merged
Johnlon merged 5 commits intocucumber:mainfrom May 30, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 83.21% 79.56% -3.65%
==========================================
Files 28 40 +12
Lines 3413 3117 -296
==========================================
- Hits 2840 2480 -360
- Misses 458 518 +60
- Partials 115 119 +4 ☔ View full report in Codecov by Sentry. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Added _example/attachments.
Added further test case for multiple calls to Attach() within a single step.
Code review comment applied - use a slice of object instead of slice of pointer
⚡️ What's your motivation?
Comments made here #623
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.