Improve ErrSkip handling, add test for Summary and operations order#584
Merged
Improve ErrSkip handling, add test for Summary and operations order#584
Conversation
Go API Changes# summary Inferred base version: v0.13.0 Suggested version: v0.13.1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
+ Coverage 82.93% 83.22% +0.28%
==========================================
Files 28 28
Lines 3411 3416 +5
==========================================
+ Hits 2829 2843 +14
+ Misses 467 458 -9
Partials 115 115
☔ View full report in Codecov by Sentry. |
6038fe9 to
3f83471
Compare
3f83471 to
85d342a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR
errors.Isfor better reliability with wrappingErrSkipSummary()and step execution flow⚡️ What's your motivation?
#582 introduced a fix that was invisible for current test suite (tests passing before and after), while covering the fix with a regression test it turned out,
ErrSkipis not properly reported inSummary().🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.