Improve example with concurrency support#573
Merged
Conversation
Go API Changes# github.com/cucumber/godog ## incompatible changes (*ScenarioContext).AfterScenario: changed from func(func(sc *github.com/cucumber/messages-go/v16.Pickle, err error)) to func(func(sc *github.com/cucumber/messages/go/v21.Pickle, err error)) (*ScenarioContext).AfterStep: changed from func(func(st *github.com/cucumber/messages-go/v16.PickleStep, err error)) to func(func(st *github.com/cucumber/messages/go/v21.PickleStep, err error)) (*ScenarioContext).BeforeScenario: changed from func(func(sc *github.com/cucumber/messages-go/v16.Pickle)) to func(func(sc *github.com/cucumber/messages/go/v21.Pickle)) (*ScenarioContext).BeforeStep: changed from func(func(st *github.com/cucumber/messages-go/v16.PickleStep)) to func(func(st *github.com/cucumber/messages/go/v21.PickleStep)) AfterScenarioHook: changed from func(context.Context, *github.com/cucumber/messages-go/v16.Pickle, error) (context.Context, error) to func(context.Context, *github.com/cucumber/messages/go/v21.Pickle, error) (context.Context, error) AfterStepHook: changed from func(context.Context, *github.com/cucumber/messages-go/v16.PickleStep, github.com/cucumber/godog/internal/models.StepResultStatus, error) (context.Context, error) to func(context.Context, *github.com/cucumber/messages/go/v21.PickleStep, github.com/cucumber/godog/internal/models.StepResultStatus, error) (context.Context, error) BeforeScenarioHook: changed from func(context.Context, *github.com/cucumber/messages-go/v16.Pickle) (context.Context, error) to func(context.Context, *github.com/cucumber/messages/go/v21.Pickle) (context.Context, error) BeforeStepHook: changed from func(context.Context, *github.com/cucumber/messages-go/v16.PickleStep) (context.Context, error) to func(context.Context, *github.com/cucumber/messages/go/v21.PickleStep) (context.Context, error) DocString: changed from github.com/cucumber/messages-go/v16.PickleDocString to github.com/cucumber/messages/go/v21.PickleDocString GherkinDocument: changed from github.com/cucumber/messages-go/v16.GherkinDocument to github.com/cucumber/messages/go/v21.GherkinDocument Scenario: changed from github.com/cucumber/messages-go/v16.Pickle to github.com/cucumber/messages/go/v21.Pickle Step: changed from github.com/cucumber/messages-go/v16.PickleStep to github.com/cucumber/messages/go/v21.PickleStep Table: changed from github.com/cucumber/messages-go/v16.PickleTable to github.com/cucumber/messages/go/v21.PickleTable ## compatible changes ErrSkip: added ScenarioContext.AfterScenario: added ScenarioContext.AfterStep: added ScenarioContext.BeforeScenario: added ScenarioContext.BeforeStep: added ScenarioContext.Given: added ScenarioContext.Step: added ScenarioContext.StepContext: added ScenarioContext.Then: added ScenarioContext.When: added # github.com/cucumber/godog/formatters ## incompatible changes Formatter.Defined: changed from func(*github.com/cucumber/messages-go/v16.Pickle, *github.com/cucumber/messages-go/v16.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) Formatter.Failed: changed from func(*github.com/cucumber/messages-go/v16.Pickle, *github.com/cucumber/messages-go/v16.PickleStep, *StepDefinition, error) to func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition, error) Formatter.Feature: changed from func(*github.com/cucumber/messages-go/v16.GherkinDocument, string, []byte) to func(*github.com/cucumber/messages/go/v21.GherkinDocument, string, []byte) Formatter.Passed: changed from func(*github.com/cucumber/messages-go/v16.Pickle, *github.com/cucumber/messages-go/v16.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) Formatter.Pending: changed from func(*github.com/cucumber/messages-go/v16.Pickle, *github.com/cucumber/messages-go/v16.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) Formatter.Pickle: changed from func(*github.com/cucumber/messages-go/v16.Pickle) to func(*github.com/cucumber/messages/go/v21.Pickle) Formatter.Skipped: changed from func(*github.com/cucumber/messages-go/v16.Pickle, *github.com/cucumber/messages-go/v16.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) Formatter.Undefined: changed from func(*github.com/cucumber/messages-go/v16.Pickle, *github.com/cucumber/messages-go/v16.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) ## compatible changes Given: added Keyword: added None: added StepDefinition.Keyword: added Then: added When: added # summary Inferred base version: v0.12.6 Suggested version: v0.13.0 |
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 28 28
Lines 3412 3412
=======================================
Hits 2830 2830
Misses 467 467
Partials 115 115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Our example suite was implemented around a global shared resource and did not run properly with concurrency enabled. This PR uses contextualized data separation to showcase concurrency support in that example.
⚡️ What's your motivation?
Fixes #572.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Nothing.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.