Skip to content

Result of testing.T respect strict option#539

Merged
vearutop merged 2 commits intocucumber:mainfrom
eiel:testingT-respect-strict-option
Apr 3, 2023
Merged

Result of testing.T respect strict option#539
vearutop merged 2 commits intocucumber:mainfrom
eiel:testingT-respect-strict-option

Conversation

@eiel
Copy link
Copy Markdown
Contributor

@eiel eiel commented Feb 19, 2023

🤔 What's changed?

result of testing.T respect strict option

⚡️ What's your motivation?

Fixes #536

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@eiel eiel changed the title Testing t respect strict option result of testing.T respect strict option Feb 19, 2023
@eiel eiel changed the title result of testing.T respect strict option Result of testing.T respect strict option Feb 19, 2023
@soulcodex
Copy link
Copy Markdown

This MR seems interesting to be merged, make sense 😄

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2023

Codecov Report

Merging #539 (c30d91b) into main (6ce2b86) will decrease coverage by 0.70%.
The diff coverage is 0.00%.

❗ Current head c30d91b differs from pull request most recent head 72e5f80. Consider uploading reports for the commit 72e5f80 to get more accurate results

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   82.94%   82.24%   -0.70%     
==========================================
  Files          28       27       -1     
  Lines        3371     3340      -31     
==========================================
- Hits         2796     2747      -49     
- Misses        461      484      +23     
+ Partials      114      109       -5     
Impacted Files Coverage Δ
suite.go 89.26% <0.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@davidedmondsMPG
Copy link
Copy Markdown

Is there anything we can do to help get this one merged and released?

@vearutop vearutop enabled auto-merge (squash) April 3, 2023 14:01
@vearutop vearutop disabled auto-merge April 3, 2023 14:02
@vearutop vearutop force-pushed the testingT-respect-strict-option branch from c30d91b to 72e5f80 Compare April 3, 2023 14:02
@vearutop vearutop merged commit dc8c9c4 into cucumber:main Apr 3, 2023
@aslakhellesoy
Copy link
Copy Markdown
Contributor

Hi @eiel,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running as subtest does not respect Strict option

5 participants