Skip to content

chore(*): BREAKING CHANGE, use new repos for cucumber and messages#515

Merged
vearutop merged 2 commits intocucumber:mainfrom
otrava7:migrate-cucumber-modules
Jan 5, 2023
Merged

chore(*): BREAKING CHANGE, use new repos for cucumber and messages#515
vearutop merged 2 commits intocucumber:mainfrom
otrava7:migrate-cucumber-modules

Conversation

@otrava7
Copy link
Copy Markdown

@otrava7 otrava7 commented Dec 30, 2022

🤔 What's changed?

  • Migrate cucumber and messages to new repos

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@otrava7 otrava7 requested a review from vearutop January 4, 2023 12:07
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 4, 2023 •
edited
Loading

Codecov Report

Merging #515 (66822af) into main (9007f1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          27       27           
  Lines        2282     2282           
=======================================
  Hits         1860     1860           
  Misses        321      321           
  Partials      101      101
Impacted Files Coverage Δ
formatters/fmt.go 100.00% <ø> (ø)
internal/formatters/fmt.go 72.72% <ø> (ø)
internal/formatters/fmt_base.go 86.17% <ø> (ø)
internal/formatters/fmt_cucumber.go 84.76% <ø> (ø)
internal/formatters/fmt_events.go 97.09% <ø> (ø)
internal/formatters/fmt_multi.go 91.66% <ø> (ø)
internal/formatters/fmt_pretty.go 81.39% <ø> (ø)
internal/formatters/fmt_progress.go 93.15% <ø> (ø)
internal/formatters/undefined_snippets_gen.go 41.46% <ø> (ø)
internal/models/feature.go 100.00% <ø> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vearutop
Copy link
Copy Markdown
Member

vearutop commented Jan 5, 2023

All good! Since this is a breaking change, let me release v0.12.6 of the current code before we merge this.

@vearutop vearutop force-pushed the migrate-cucumber-modules branch from a036ebd to 66822af Compare January 5, 2023 10:01
@vearutop vearutop changed the title chore(*): use new repos for cucumber and messages chore(*): BREAKING CHANGE, use new repos for cucumber and messages Jan 5, 2023
@vearutop vearutop merged commit 2264a00 into cucumber:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vearutop vearutop vearutop approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@otrava7 @vearutop