Fix version subcommand. Do not print usage if run subcommand fails.#475
Merged
vearutop merged 2 commits intocucumber:mainfrom May 20, 2022
Merged
Fix version subcommand. Do not print usage if run subcommand fails.#475vearutop merged 2 commits intocucumber:mainfrom
vearutop merged 2 commits intocucumber:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 27 27
Lines 2197 2197
=======================================
Hits 1789 1789
Misses 312 312
Partials 96 96 Continue to review full report at Codecov.
|
vearutop
approved these changes
May 20, 2022
Member
vearutop
left a comment
There was a problem hiding this comment.
Thank you for fixing this. 👍
Contributor
|
Hi @coopernurse, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
godog versionnow prints the version number again andgodog runwill no longer print usage if a test fails.⚡️ What's your motivation?
godog versionwasn't printing the version numbergodog runwas printing usage when a test failed, which cluttered up the output, and didn't seem intentional🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Would you like the CHANGELOG updated for this?
📋 Checklist: