Skip to content

Add WSL friendly check-go-version setup#443

Merged
mattwynne merged 5 commits intomainfrom
wsl-go-check
Dec 1, 2021
Merged

Add WSL friendly check-go-version setup#443
mattwynne merged 5 commits intomainfrom
wsl-go-check

Conversation

@mxygem
Copy link
Copy Markdown
Member

@mxygem mxygem commented Nov 30, 2021

Description

I've written a new version check that jives with WSL. I haven't tested this against macOS or other envs, so if others could help with that, I'd appreciate it!

Motivation & context

Currently folks utilizing WSL are unable to run make test as execution of the version check fails.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mxygem mxygem requested review from mattwynne and vearutop November 30, 2021 20:37
@mxygem mxygem self-assigned this Nov 30, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 30, 2021 •
edited
Loading

Codecov Report

Merging #443 (390a064) into main (df29469) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   81.58%   81.58%           
=======================================
  Files          26       26           
  Lines        2177     2177           
=======================================
  Hits         1776     1776           
  Misses        308      308           
  Partials       93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df29469...390a064. Read the comment docs.

vearutop
vearutop approved these changes Nov 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vearutop vearutop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me both in WSL Ubuntu 20.04 and macos.

@mattwynne
Copy link
Copy Markdown
Member

mattwynne commented Nov 30, 2021

Nice work @mxygem! The only nit-pick I have with this is that I see this in my terminal:

make: Nothing to be done for `check-go-version'.

I think that last commit has fixed that. Can you check it still works on WSL?

vearutop
vearutop reviewed Dec 1, 2021
View reviewed changes
@mxygem @vearutop
Update CHANGELOG.md
390a064 
Co-authored-by: Viacheslav Poturaev <vearutop@gmail.com>
@mxygem
Copy link
Copy Markdown
Member Author

mxygem commented Dec 1, 2021

Nice work @mxygem! The only nit-pick I have with this is that I see this in my terminal:

make: Nothing to be done for `check-go-version'.

I think that last commit has fixed that. Can you check it still works on WSL?

Yea! Nice job. That error shouldn't happen when versions match when make test is run, only when it's run directly.

@mattwynne mattwynne merged commit 82bcce7 into main Dec 1, 2021
@mxygem mxygem deleted the wsl-go-check branch December 1, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vearutop vearutop vearutop approved these changes

@mattwynne mattwynne Awaiting requested review from mattwynne

Assignees

@mxygem mxygem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mxygem @mattwynne @vearutop