Skip to content

make test failure on go1.23.2 due to statickcheck@0.4.7 #672

@skiz

Description

@skiz

👓 What did you see?

The Makefile runs staticcheck@0.4.7 which does not run on go1.23.2,

test: check-go-version
	@echo "running all tests"
	@go fmt ./...
	@go run honnef.co/go/tools/cmd/staticcheck@v0.4.7 github.com/cucumber/godog
	@go run honnef.co/go/tools/cmd/staticcheck@v0.4.7 github.com/cucumber/godog/cmd/godog
	go vet ./...
	go test -race ./...
	go run ./cmd/godog -f progress -c 4

Updating the Makefile to use @v0.5.0 does make the staticcheck work, however I'm not sure if there are incompatibilities with older versions of go.

✅ What did you expect to see?

Passing tests.

📦 Which tool/library version are you using?

godog@head

🔬 How could we reproduce it?

Install Go Version Manager (gvm)
Install and activate Go1.23.2
run make test

📚 Any additional context?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions