Skip to content

Remove the Java Gherkin parser. Rely on Go binary/protobuf#424

Merged
aslakhellesoy merged 7 commits intomasterfrom
gherkin-java-protobuf-only
Jul 3, 2018
Merged

Remove the Java Gherkin parser. Rely on Go binary/protobuf#424
aslakhellesoy merged 7 commits intomasterfrom
gherkin-java-protobuf-only

Conversation

@aslakhellesoy
Copy link
Contributor

@aslakhellesoy aslakhellesoy commented Jul 2, 2018 •
edited
Loading

Summary

The Java Gherkin parser is gone!

Details

Parsing is delegated to a subprocess (gherkin-go executable)
The package has moved to io.cucumber.gherkin

Motivation and Context

Less code to maintain.

TODO

  • Package prebuilt go binaries for various platforms
  • Detect platform and extract the right binary
  • Detect more platforms - see protoc-jar
  • Download binary from S3 if not in jar
  • Set up build process

@aslakhellesoy aslakhellesoy changed the title Remove the Java Gherkin parser. Rely on Go binary/protobuf [WIP] Remove the Java Gherkin parser. Rely on Go binary/protobuf Jul 2, 2018
@aslakhellesoy
Copy link
Contributor Author

aslakhellesoy commented Jul 2, 2018

Currently, in order to build this, you have to:

cd gherkin/go
make cross-compile
cd ../java
mkdir gherkin-go && cp ../go/dist/*

We can automate that for the monorepo build, but for the subrepo build, ../go is not available. I think the best is to download the binaries from GitHub in that case. The publish-release target in gherkin/go can do the upload.

@aslakhellesoy aslakhellesoy mentioned this pull request Jul 3, 2018
Closed
45 tasks
@aslakhellesoy aslakhellesoy changed the title [WIP] Remove the Java Gherkin parser. Rely on Go binary/protobuf Remove the Java Gherkin parser. Rely on Go binary/protobuf Jul 3, 2018
@aslakhellesoy aslakhellesoy merged commit ce718d9 into master Jul 3, 2018
@mlvandijk
Copy link
Member

mlvandijk commented Jul 3, 2018

fyi, make cross-compile gave me an error; command 'gox' not recognized (or something similar).
Adding the following to my .bash_profile fixed it:

Add go bin to path

export PATH=$(go env GOPATH)/bin:${PATH}

@mlvandijk
Copy link
Member

mlvandijk commented Jul 3, 2018

Also cp ../go/dist/* ./gherkin-go to copy the files to the created dir

@aslakhellesoy
Copy link
Contributor Author

aslakhellesoy commented Jul 3, 2018

You shouldn't have to do that @mlvandijk - MagicFile will download from S3.

@aslakhellesoy aslakhellesoy deleted the gherkin-java-protobuf-only branch July 12, 2018 21:11
@lock
Copy link

lock bot commented Jul 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@brasmusson brasmusson Awaiting requested review from brasmusson

@mpkorstanje mpkorstanje Awaiting requested review from mpkorstanje

@mlvandijk mlvandijk Awaiting requested review from mlvandijk

Assignees

No one assigned

Labels

language: java library: gherkin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslakhellesoy @mlvandijk