fix flower and foliage generation#4723
fix flower and foliage generation#4723tigerw merged 34 commits intocuberite:masterfrom mBornand:flower
Conversation
Remove duplication of grass generation Remove fern in inapropriate biomes
|
Looking |
|
It seems cFinishGenSprinkleFoliage has been somewhat gutted, was all of its functionality preserved in the migration to FinishGenClumpTopBlock? E.g. there is a |
|
@mBornand Any chance that you are going to get back to this, I would like to get this merged in. |
There weren't any checksat all. If the terrain would have caused an invalid height for the placed block the server would have crashed |
| { | ||
| // Initialize the vector for all biomes. | ||
| for (int i = static_cast<int>(a_Output.size()); i < static_cast<int>(biMaxVariantBiome); i++) | ||
| for (int i = static_cast<int>(a_Output.size()); i <= static_cast<int>(biMaxVariantBiome); i++) |
There was a problem hiding this comment.
when using biMesaPlateauM = biMaxVariantBiome the server crashed
|
yeah seems good, not sure if anyone has any screenshots for the record? |
|
i'm gonna make some |
Remove duplication of grass generation Remove fern in inapropriate biomes
made one line clearer
|
This PR: Bright grass: Sunflower Plains The Screenschots are in WQHD - feel free to zoom in |
+ Style + Use empty() + Emplace directly + Avoid a string copy in BiomeName + Alias BiomeIndex to avoid multiple casts
Activate flower generation.
Fixes #238
Fixes #241
The main base of the code was already present, but it contained some mistakes.