Closed
Conversation
fa053bb to
0466183
Compare
Contributor
Author
|
Had thought about adding a static function to deserialize from json string, but I think the API functions are already enough. |
bearbin
reviewed
Apr 5, 2020
- Added new class cBookContent that contains the infos about a book - Loads and saves the book from player inventory and nbt - Added hooks: HOOK_PLAYER_EDITING_BOOK and HOOK_PLAYER_EDITED_BOOK
Contributor
Author
|
I tested against 1.8 and there written book are stored as simple strings and not as json strings. |
Contributor
Author
|
Okay, it's sent as a json string in 1.8, but the text is escaped: {
"text" : "1\n2\n3\n4\n5"
}1.8: {
"text" : "\"1\\n2\\n3\\n4\\n5\""
}Should we change the content, before it's sent or when it's received? Or ignore it as it's only in 1.8? |
Member
|
When it's received seems to make more sense. Since we do support 1.8 still, we should make all features that can work in that version work. |
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revived that old branch. Tested and it works in 1.8.9, 1.9.4 and 1.12.2.
Will check the API and look to extend it with
cJson.