Remove rust-toolchain and fix some typos#27
Merged
cswinter merged 5 commits intocswinter:masterfrom Sep 18, 2018
zhzy0077:fix/refine
Merged
Remove rust-toolchain and fix some typos#27cswinter merged 5 commits intocswinter:masterfrom zhzy0077:fix/refine
cswinter merged 5 commits intocswinter:masterfrom
zhzy0077:fix/refine
Conversation
…d. Therefore we don't need to specify toolchain version.
Owner
|
Nice, thanks for the contribution! I think there is still value in keeping the rust-toolchain to guard against any future changes to nightly Rust and make it unnecessary to manually update the compiler version. |
Contributor
Author
|
@cswinter Well, it would be better if we can update toolchain version since we are unable to use clippy on current version. |
Owner
|
@zhzy0077 Oh for sure, please do update the toolchain to the latest version! Having clippy would be great, and not letting the version fall too far behind is good also. |
Owner
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the name changes, rust-lang/rust#51919, to_bytes has renamed to to_ne_bytes. After the change, we don't need to specify the toolchain version.
Also some typos and needless lifetimes have been fixed.