Severity aware resolution #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issues history (including individual issues view) currently always shows
Resolved after <x time> of Downtimeeven if the issue severity is marked asdisrupted.This change seeks to remove the
of Downtimeor language equivalent if the issue severity is anything other thandown. The approach is to avoid grammar and i18n changes while also acknowledging the issue's severity.Change
Minimal change to only apply the
ofDowntimemapped text if the issue severity isdownTest plan
Pre-Reqs
downand resolved after time diff is over 1 minutedisruptedand resolved after time diff is over 1 minutedownand resolved after time diff is over 1 hourdisruptedand resolved after time diff is over 1 hourdisableIncidentHistory: falseTest Cases
After serving up the page check the following scenarios
disruptedseverity do no showofDowntimemapped text (of Downtime)..downseverity showofDowntimemapped text (of Downtime)..Screen Shots

Closing issues
Closes #264