fix(postcss-merge-rules): check for ms vendor#480
Merged
alexander-akait merged 3 commits intocssnano:masterfrom May 29, 2018
Merged
fix(postcss-merge-rules): check for ms vendor#480alexander-akait merged 3 commits intocssnano:masterfrom
alexander-akait merged 3 commits intocssnano:masterfrom
Conversation
Member
|
Maybe we should check not just prefix but whole selector? To be sure that it is placeholder selector? |
Member
|
Yep, looks like better use |
alexander-akait
requested changes
May 29, 2018
|
|
||
| // Internet Explorer use :-ms-input-placeholder. | ||
| // Microsoft Edge use ::-ms-input-placeholder. | ||
| const findMsInputPlaceholder = selector => ~selector.indexOf('-ms-input-placeholder'); |
Member
There was a problem hiding this comment.
Better use regex with i flag, because css is case insensitivity language
Contributor
Author
There was a problem hiding this comment.
Oh, well, I did not think about it
alexander-akait
approved these changes
May 29, 2018
Member
|
@evless Thanks for work! |
Contributor
Author
|
@evilebottnawi I apologize, but can I make a commit with the addition of a list of contributors? :) |
Member
|
@evless yep, feel free to send PR 👍 |
Member
|
@evless Send PR to this page https://github.com/ben-eb/cssnano/blob/master/CONTRIBUTORS.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #419