-
-
Notifications
You must be signed in to change notification settings - Fork 324
fix: improve font-family handling
#456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| test( | ||
| 'should correctly escape special characters at the end', | ||
| processCSS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use passthroughCSS for any test where the output is the same as the input.
|
Maybe add |
|
@andyjansson let's do it 👍 |
4e3317a to
0c7dd79
Compare
|
FYI: for test https://mothereff.in/font-family
In code we have comment: But i will fix it anyway 👍 |
|
@andyjansson can you give me invite i close some invalid issues (with tests if needed) |
Yeah, I know. I don't think the comment applies anymore. I modified your code to include |
|
@andyjansson hm, let's do it |
0c7dd79 to
7f0b4b4
Compare
|
/cc @andyjansson done, also fix some cases with lowercase/uppercase with tests |
fixes #430 fixes #434
Also fix buggy tests. Can add more tests.