Skip to content

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Mar 30, 2018

fixes #430 fixes #434
Also fix buggy tests. Can add more tests.

@coveralls
Copy link

coveralls commented Mar 30, 2018

Coverage Status

Coverage decreased (-0.1%) to 99.485% when pulling 7f0b4b4 on evilebottnawi:issue-430 into cd92638 on ben-eb:master.


test(
'should correctly escape special characters at the end',
processCSS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use passthroughCSS for any test where the output is the same as the input.

@andyjansson
Copy link
Contributor

Maybe add monospace to keywords? I don't think the comment applies anymore. Also, I think we can also address #434 easily by making any checks against keywords case insensitive.

@alexander-akait
Copy link
Member Author

@andyjansson let's do it 👍

@alexander-akait
Copy link
Member Author

FYI: for test https://mothereff.in/font-family

Maybe add monospace to keywords

In code we have comment:

// Note that monospace is missing intentionally from this list; we should not
// remove instances of duplicated monospace keywords, it causes the font to be
// rendered smaller in Chrome.

But i will fix it anyway 👍

@alexander-akait
Copy link
Member Author

@andyjansson can you give me invite i close some invalid issues (with tests if needed)

@andyjansson
Copy link
Contributor

In code we have comment:

// Note that monospace is missing intentionally from this list; we should not
// remove instances of duplicated monospace keywords, it causes the font to be
// rendered smaller in Chrome.

Yeah, I know. I don't think the comment applies anymore. I modified your code to include monospace in the keywords collection and the should not dedupe monospace and should not dedupe monospace (2) tests pass just the same.

@alexander-akait
Copy link
Member Author

@andyjansson hm, let's do it

@alexander-akait
Copy link
Member Author

/cc @andyjansson done, also fix some cases with lowercase/uppercase with tests

@andyjansson andyjansson merged commit fbb1385 into cssnano:master Apr 19, 2018
@alexander-akait alexander-akait deleted the issue-430 branch April 19, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing quotes of font-family will make it invalid removeQuotes error for minifyFontValues.

3 participants