Skip to content

sidecar: Use zap as logger backend#770

Merged
mergify[bot] merged 1 commit into
csi-addons:mainfrom
black-dragon74:use-zap-logger
Feb 17, 2025
Merged

sidecar: Use zap as logger backend#770
mergify[bot] merged 1 commit into
csi-addons:mainfrom
black-dragon74:use-zap-logger

Conversation

@black-dragon74

@black-dragon74 black-dragon74 commented Feb 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This patch sets zap as logger backend for klog
and controller runtime.

Setting the logger is required by controller runtime, not doing so leads to an error in the logs like:

[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
        >  goroutine 26 [running]:
        >  runtime/debug.Stack()
        >       /usr/local/go/src/runtime/debug/stack.go:26 +0x5e
        >  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
        ....

Madhu-1
Madhu-1 reviewed Feb 17, 2025
View reviewed changes

@Madhu-1 Madhu-1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description/commit message to show what exact error you are seeing now without this change.

@black-dragon74 black-dragon74 mentioned this pull request Feb 17, 2025
Merged
@black-dragon74
sidecar: Use zap as logger backend
42faeec 
This patch sets `zap` as logger backend for klog
and controller runtime.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
@mergify mergify Bot merged commit 6e0f6e0 into csi-addons:main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@iPraveenParihar iPraveenParihar Awaiting requested review from iPraveenParihar

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

@yati1998 yati1998 Awaiting requested review from yati1998

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@black-dragon74 @nixpanic @Madhu-1