Lower case should be used for HTTP/2 fields#756
Merged
Conversation
Madhu-1
approved these changes
Jan 22, 2025
nixpanic
approved these changes
Jan 22, 2025
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Member
|
@Mergifyio rebase |
Signed-off-by: Bipul Adhikari <badhikar@redhat.com>
Signed-off-by: Bipul Adhikari <badhikar@redhat.com>
✅ Branch has been successfully rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://www.ietf.org/archive/id/draft-ietf-httpbis-http2bis-02.html#section-8.1.2 lower case should be used and gRPC library is automatically converting to lower case.
Fixes issue #750