Fix key in connection pool#704
Merged
Merged
Conversation
as its been 2 years to support legacy endpoint, lets remove the support for it. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
nixpanic
reviewed
Nov 12, 2024
In the connection pool we store the connection with unique identifier, the pod name and the namespace is used as the key to the connection in the pool and GetLeaderByDriver get the leader based on the driver name and uses the identity of the leader which is pod name as the key to get the connection. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
f53860f to
c5b80c9
Compare
nixpanic
approved these changes
Nov 12, 2024
yati1998
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the connection pool we store the connection with unique identifier, the pod name and the namespace is used as the key to the connection in the pool and GetLeaderByDriver get the leader based on the driver name and uses the identity of the leader which is pod name as the key to get the connection.