Skip to content

rebase: use go.mod for go version#684

Merged
mergify[bot] merged 1 commit into
csi-addons:mainfrom
Madhu-1:use-go.mod
Sep 24, 2024
Merged

rebase: use go.mod for go version#684
mergify[bot] merged 1 commit into
csi-addons:mainfrom
Madhu-1:use-go.mod

Conversation

@Madhu-1

@Madhu-1 Madhu-1 commented Sep 24, 2024

Copy link
Copy Markdown
Member

instead of defining own go version in test files we can use go.mod to setup the required version.

@black-dragon74

Copy link
Copy Markdown
Member

Additional ref: https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file

instead of defining own go version
in test files we can use go.mod to setup
the required version.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

@nixpanic nixpanic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, much simpler!

@mergify mergify Bot merged commit bd951fb into csi-addons:main Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants