test: Add testing tool for VolumeGroup#678
Merged
Merged
Conversation
Contributor
|
@ShravaniVangur can you please also paste the successful output for the above CLI commands? |
73ce861 to
2c7bdb6
Compare
2c7bdb6 to
86bd3d6
Compare
Madhu-1
requested changes
Sep 24, 2024
86bd3d6 to
7ed1aee
Compare
Madhu-1
reviewed
Sep 25, 2024
7ed1aee to
22cb6a7
Compare
nixpanic
previously approved these changes
Oct 15, 2024
nixpanic
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but it you want to cleanup the formatting/emptylines that would be appreciated.
| var _ = registerOperation("CreateVolumeGroup", &CreateVolumeGroup{}) | ||
|
|
||
| func (cvg *CreateVolumeGroup) Init(c *command) error { | ||
|
|
Member
There was a problem hiding this comment.
Interesting choice of empty lines. The functions above don't have any, and here you start to add more.
Can you make that a little more equal throughout the file?
22cb6a7 to
4597042
Compare
Pull request has been modified.
4597042 to
f9cc8d3
Compare
yati1998
approved these changes
Oct 16, 2024
Madhu-1
approved these changes
Oct 16, 2024
Member
|
@Mergifyio rebase |
This adds testing tool for VolumeGroup operations. Signed-off-by: ShravaniVangur <shravanivangur@gmail.com>
✅ Branch has been successfully rebased |
f9cc8d3 to
c6bbb24
Compare
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 9c3beb8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds testing tool for VolumeGroup operations such as-
Resolves #653
Sample outputs for the cli commands of the form:
kubectl exec -c csi-addons <csi-addons-nodeplugin> -n rook-ceph -- csi-addons -operation <operationName> -secret <namespace/name> -parameters <key1=value1,...>CreateVolumeGroup:
Volume Group created: volume_group:{volume_group_id:"0001-0009-rook-ceph-0000000000000002-21fb957f-7987-44f8-972c-36c6e57896b0"}ModifyVolumeGroupMembership:
Volume Group Membership modified for- volume_group:{volume_group_id:"0001-0009-rook-ceph-0000000000000002-21fb957f-7987-44f8-972c-36c6e57896b0"}DeleteVolumeGroup:
Volume Group Deleted.ControllerGetVolumeGroup:
Controller Volume Group Info: volume_group:{volume_group_id:"0001-0009-rook-ceph-0000000000000002-21fb957f-7987-44f8-972c-36c6e578"}