Skip to content

Add proto and sidecar code for volumegroup#652

Merged
mergify[bot] merged 3 commits into
csi-addons:mainfrom
Nikhil-Ladha:add-volumegroup-proto
Aug 30, 2024
Merged

Add proto and sidecar code for volumegroup#652
mergify[bot] merged 3 commits into
csi-addons:mainfrom
Nikhil-Ladha:add-volumegroup-proto

Conversation

@Nikhil-Ladha

Copy link
Copy Markdown
Contributor

This PR adds the following codes/logic:

  • Updated the csi-addons spec api
  • Added volume group proto files
  • Added volume group sidecar and client setup

@mergify mergify Bot added the vendor Pull requests that update vendored dependencies label Aug 28, 2024
@Nikhil-Ladha

Nikhil-Ladha commented Aug 28, 2024

Copy link
Copy Markdown
Contributor Author

Created a separate PR for proto and sidecar code (will remove these commits from #610 ) so that we can merge this and later on take the controller code once ceph code is merged.

@Nikhil-Ladha

Copy link
Copy Markdown
Contributor Author

@nixpanic @Madhu-1 @Rakshith-R can you please take a look.

Comment thread internal/proto/volumegroup.proto
Comment thread internal/proto/volumegroup.proto
Comment thread internal/proto/volumegroup.proto Outdated
Comment thread internal/sidecar/service/volumegroup.go Outdated
Madhu-1
Madhu-1 previously approved these changes Aug 29, 2024
Comment thread internal/proto/volumegroup.proto
Comment thread internal/proto/volumegroup.proto Outdated
@Nikhil-Ladha Nikhil-Ladha force-pushed the add-volumegroup-proto branch from 54f64dc to ae53c59 Compare August 29, 2024 10:42
@mergify mergify Bot dismissed Madhu-1’s stale review August 29, 2024 10:43

Pull request has been modified.

@Rakshith-R Rakshith-R left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpanic

Copy link
Copy Markdown
Member

Looks good to me. @Madhu-1 do you want to have a final look?

@Nikhil-Ladha

Copy link
Copy Markdown
Contributor Author

@Mergifyio refresh

@mergify

mergify Bot commented Aug 30, 2024

Copy link
Copy Markdown

refresh

✅ Pull request refreshed

@Madhu-1

Madhu-1 commented Aug 30, 2024

Copy link
Copy Markdown
Member

@Mergifyio rebase

updated csi-addons spec api to latest version

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
added required proto files and generated grpc
library for internal communications of volume
groups.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
added sidecar service and client setup code for volume group
feature

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
@mergify

mergify Bot commented Aug 30, 2024

Copy link
Copy Markdown

rebase

✅ Branch has been successfully rebased

@Madhu-1 Madhu-1 force-pushed the add-volumegroup-proto branch from ae53c59 to ce0d2b7 Compare August 30, 2024 12:28
@mergify mergify Bot merged commit 32e811c into csi-addons:main Aug 30, 2024
lumiere-bot Bot referenced this pull request in coolguy1771/home-ops Sep 19, 2024
… ) (#5423)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[kubernetes-csi-addons](https://redirect.github.com/csi-addons/kubernetes-csi-addons)
| minor | `v0.9.1` -> `v0.10.0` |

---

### Release Notes

<details>
<summary>csi-addons/kubernetes-csi-addons
(kubernetes-csi-addons)</summary>

###
[`v0.10.0`](https://redirect.github.com/csi-addons/kubernetes-csi-addons/releases/tag/v0.10.0)

[Compare
Source](https://redirect.github.com/csi-addons/kubernetes-csi-addons/compare/v0.9.1...v0.10.0)

#### What's Changed

- Add proto and sidecar code for volumegroup by
[@&#8203;Nikhil-Ladha](https://redirect.github.com/Nikhil-Ladha) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/652](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/652)
- vendor: Bump google.golang.org/grpc from 1.65.0 to 1.66.0 in the
golang-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/656](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/656)
- vendor: Bump sigs.k8s.io/controller-tools from 0.16.1 to 0.16.2 in
/tools in the k8s-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/658](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/658)
- vendor: Bump the github-dependencies group across 1 directory with 3
updates by [@&#8203;dependabot](https://redirect.github.com/dependabot)
in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/657](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/657)
- replication: add new Validated condition by
[@&#8203;Rakshith-R](https://redirect.github.com/Rakshith-R) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/664](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/664)
- bundle: Update CSV capability to Seamless Upgrades by
[@&#8203;black-dragon74](https://redirect.github.com/black-dragon74) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/668](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/668)
- Refactor PVC controller by
[@&#8203;black-dragon74](https://redirect.github.com/black-dragon74) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/662](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/662)
- bundle: Add missing CRDs to bundle CSV by
[@&#8203;black-dragon74](https://redirect.github.com/black-dragon74) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/669](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/669)
- vendor: bump the k8s-dependencies group with 3 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/673](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/673)

#### New Contributors

- [@&#8203;Nikhil-Ladha](https://redirect.github.com/Nikhil-Ladha) made
their first contribution in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/652](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/652)

**Full Changelog**:
csi-addons/kubernetes-csi-addons@v0.9.1...v0.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44NS4wIiwidXBkYXRlZEluVmVyIjoiMzguODUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL21pbm9yIl19-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
spiceratops referenced this pull request in spiceratops/k8s-gitops Sep 26, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[kubernetes-csi-addons](https://redirect.github.com/csi-addons/kubernetes-csi-addons)
| minor | `v0.9.1` -> `v0.10.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>csi-addons/kubernetes-csi-addons
(kubernetes-csi-addons)</summary>

###
[`v0.10.0`](https://redirect.github.com/csi-addons/kubernetes-csi-addons/releases/tag/v0.10.0)

[Compare
Source](https://redirect.github.com/csi-addons/kubernetes-csi-addons/compare/v0.9.1...v0.10.0)

#### What's Changed

- Add proto and sidecar code for volumegroup by
[@&#8203;Nikhil-Ladha](https://redirect.github.com/Nikhil-Ladha) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/652](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/652)
- vendor: Bump google.golang.org/grpc from 1.65.0 to 1.66.0 in the
golang-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/656](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/656)
- vendor: Bump sigs.k8s.io/controller-tools from 0.16.1 to 0.16.2 in
/tools in the k8s-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/658](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/658)
- vendor: Bump the github-dependencies group across 1 directory with 3
updates by [@&#8203;dependabot](https://redirect.github.com/dependabot)
in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/657](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/657)
- replication: add new Validated condition by
[@&#8203;Rakshith-R](https://redirect.github.com/Rakshith-R) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/664](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/664)
- bundle: Update CSV capability to Seamless Upgrades by
[@&#8203;black-dragon74](https://redirect.github.com/black-dragon74) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/668](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/668)
- Refactor PVC controller by
[@&#8203;black-dragon74](https://redirect.github.com/black-dragon74) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/662](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/662)
- bundle: Add missing CRDs to bundle CSV by
[@&#8203;black-dragon74](https://redirect.github.com/black-dragon74) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/669](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/669)
- vendor: bump the k8s-dependencies group with 3 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/673](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/673)

#### New Contributors

- [@&#8203;Nikhil-Ladha](https://redirect.github.com/Nikhil-Ladha) made
their first contribution in
[https://github.com/csi-addons/kubernetes-csi-addons/pull/652](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/652)

**Full Changelog**:
csi-addons/kubernetes-csi-addons@v0.9.1...v0.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44NS4wIiwidXBkYXRlZEluVmVyIjoiMzguODUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL21pbm9yIl19-->
@Nikhil-Ladha Nikhil-Ladha deleted the add-volumegroup-proto branch June 26, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vendor Pull requests that update vendored dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants