build: fix make docker-generate-protobuf target#375
Merged
Conversation
With recent changes to detect Podman/Docker, the `docker-generate-protobuf` make target was broken. The parameters to the container build command were passed like `$^`, and not only the Containerfile filename. Fixes: csi-addons#372 Signed-off-by: Niels de Vos <ndevos@ibm.com>
Madhu-1
approved these changes
Jun 21, 2023
Rakshith-R
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes to detect Podman/Docker, the
docker-generate-protobufmake target was broken. The parameters to the container build command were passed like$^, and not only the Containerfile filename.Fixes: #372