Dtype for reduction#361
Merged
jjsjann123 merged 4 commits into20_8_18_develfrom Sep 14, 2020
Merged
Conversation
Collaborator
Author
|
I'm hitting a kernel issue with the support. fp16 kernel is giving me wrong output, looks like predicate is wrong. I'll open another issue to track it. |
tlemo
approved these changes
Sep 10, 2020
| const auto out_type = node->input(0)->type()->cast<TensorType>(); | ||
| auto out_type = node->input(0)->type()->cast<TensorType>(); | ||
|
|
||
| if (!node->input(3)->type()->isSubtypeOf( |
Collaborator
There was a problem hiding this comment.
add a comment explaining what's going on?
| static_cast<c10::TypePtr>(NoneType::get()))) { | ||
| // We can only handle output as half and float; | ||
| if (auto opt_ivalue = toIValue(node->input(3))) { | ||
| auto scalar_type = opt_ivalue->toScalarType(); |
| // back to fp16. | ||
| TypePropagate(graph); | ||
| } | ||
| TypePropagate(graph); |
Collaborator
There was a problem hiding this comment.
is this still related to the corner case described in the original comment? if that's the case maybe we should preserve the comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357
Two things in this PR:
sum, which is simply handled in our type propagation.