Try to fix https://github.com/csarofeen/pytorch/issues/286#295
Merged
jjsjann123 merged 2 commits into20_7_6_develfrom Aug 15, 2020
Merged
Try to fix https://github.com/csarofeen/pytorch/issues/286#295jjsjann123 merged 2 commits into20_7_6_develfrom
jjsjann123 merged 2 commits into20_7_6_develfrom
Conversation
Owner
Author
|
CC @naoyam to remind me to talk this crazy PR through with him Monday. |
jjsjann123
approved these changes
Aug 15, 2020
Collaborator
jjsjann123
left a comment
There was a problem hiding this comment.
don't see anything wrong in this PR. Let's clean it up and get everything upstream!
| } | ||
|
|
||
| void testGPU_FusionSmemBlockGemmCache() { | ||
| #if 0 |
Collaborator
There was a problem hiding this comment.
Should we open an issue to track the breakage of this test, just so we won't forgot that something is disabled in cpp tests via macro and test is giving us a pass.
| [this](IterDomain* id) { return is_contig_root.at(id); }))) { | ||
| [this](IterDomain* id) { | ||
| return is_contig_root.at(id) && !id->isBroadcast() && | ||
| !id->isReduction(); |
Collaborator
There was a problem hiding this comment.
Does this actually fix the issue with broadcasting & contiguous simultaneously marked on a tensor?
The issue I reported in #230 actually went away in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix: #286