changing axis merge direction#294
Merged
csarofeen merged 2 commits into20_7_6_develfrom Aug 15, 2020
Merged
Conversation
Collaborator
Author
|
Should I create an issue to track the root cause of this problem, even though we are not planning for it in the near future? |
csarofeen
approved these changes
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we cannot accumulate dimension collapsing across non-contiguous dimensions. To exploit the trade-off, we decide to prioritize dimension collapsing on faster changing dimensions. Hence we update the merge directions.