Fixes https://github.com/csarofeen/pytorch/issues/292#293
Merged
csarofeen merged 2 commits into20_7_6_develfrom Aug 14, 2020
Merged
Fixes https://github.com/csarofeen/pytorch/issues/292#293csarofeen merged 2 commits into20_7_6_develfrom
csarofeen merged 2 commits into20_7_6_develfrom
Conversation
tlemo
approved these changes
Aug 14, 2020
|
|
||
| TensorView::TensorView(const fuser::TensorView* tv) : Val(tv), fuser_tv_(tv) { | ||
| domain_ = lowerValue(tv->domain())->as<TensorDomain>(); | ||
| domain_ = lowerValue(tv->domain())->as<kir::TensorDomain>(); |
Collaborator
There was a problem hiding this comment.
please remove kir:: (not needed, we're already in the kir namespace)
Owner
Author
There was a problem hiding this comment.
There's a few kir:: instances in this file, might want to look through them.
| domain_(ir_cloner->clone(src->domain_)), | ||
| memory_type_(src->memory_type_) {} | ||
| memory_type_(src->memory_type_), | ||
| fuser_tv_(src->fuser_tv_) {} |
|
|
||
| class TORCH_CUDA_API TensorView : public Val { | ||
| public: | ||
| TensorView(TensorDomain* domain, DataType dtype); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #292
CC: @tlemo