Skip to content

Heuristic cache PR#275

Merged
jjsjann123 merged 4 commits into20_7_6_develfrom
heuristic_cache
Aug 11, 2020
Merged

Heuristic cache PR#275
jjsjann123 merged 4 commits into20_7_6_develfrom
heuristic_cache

Conversation

@jjsjann123
Copy link
Copy Markdown
Collaborator

@jjsjann123 jjsjann123 commented Aug 7, 2020

  1. switched to scheduleReduction instead of naive scheduleFusion for reduction-fusion;
  2. update FusionExecutorCache to reuse kernel with ReductionParamsHash

Note:
It's failing CI test due to: #273; but luckily we have the other PR merged that disabled broadcasting, so CI is green.

@jjsjann123 jjsjann123 changed the base branch from graph_cache_PR to 20_7_6_devel August 11, 2020 18:28
@jjsjann123
Copy link
Copy Markdown
Collaborator Author

This PR is too messy. I'll rebase and force push to make review easier.

@jjsjann123 jjsjann123 changed the title [WIP] Heuristic cache PR Heuristic cache PR Aug 11, 2020
Comment thread torch/csrc/jit/codegen/cuda/executor.h Outdated

// function to query whether a `FusionExecutor` has a compiled kernel to
// execute
bool compiled() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be const

@jjsjann123
Copy link
Copy Markdown
Collaborator Author

I'm merging this guy. Feel free to leave comments, we can address them in the next round of PR.

@jjsjann123 jjsjann123 merged commit eccbf78 into 20_7_6_devel Aug 11, 2020
@csarofeen csarofeen deleted the heuristic_cache branch June 9, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants