Skip to content

Revert "Reworking loop nests, making sure we get broadcast dims."#259

Merged
naoyam merged 1 commit into20_7_6_develfrom
revert-256-contiguity_cherry_pick
Aug 1, 2020
Merged

Revert "Reworking loop nests, making sure we get broadcast dims."#259
naoyam merged 1 commit into20_7_6_develfrom
revert-256-contiguity_cherry_pick

Conversation

@naoyam
Copy link
Copy Markdown
Collaborator

@naoyam naoyam commented Aug 1, 2020

Reverts #256

#256 causes an error as shown below:

test_addcmul_ops (__main__.TestCudaFuser) ... ok
test_binary_ops (__main__.TestCudaFuser) ... ok
test_broadcasting (__main__.TestCudaFuser) ... expected failure
test_broadcasting_multiple_output (__main__.TestCudaFuser) ... skipped 'real broadcast with different output not supported yet'
test_broadcasting_multiple_output_shape (__main__.TestCudaFuser) ... skipped 'Broadcast with different output not supported yet'
test_chunk (__main__.TestCudaFuser) ... ok
test_const (__main__.TestCudaFuser) ... ok
test_dynamic_size (__main__.TestCudaFuser) ... FAIL
======================================================================
FAIL: test_dynamic_size (__main__.TestCudaFuser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/nmaruyama/pytorch/release/src1/torch/testing/_internal/common_utils.py", line 777, in wrapper
    method(*args, **kwargs)
  File "test/test_jit_cuda_fuser.py", line 401, in test_dynamic_size
    self.assertEqual(o, jit_o)
  File "/home/nmaruyama/pytorch/release/src1/torch/testing/_internal/common_utils.py", line 1085, in assertEqual
    self.assertTrue(result, msg=msg)
AssertionError: False is not true : Tensors failed to compare as equal! With rtol=1.3e-06 and atol=1e-05, found 31744 element(s) (out of 32768) whose difference(s) exceeded the margin of error (including 0 nan comparisons). The greatest difference was 4.324123978614807 (4.439993858337402 vs. 0.11586987972259521), which occurred at index (0, 1, 28, 26).
----------------------------------------------------------------------

@naoyam naoyam merged commit 4e38ce6 into 20_7_6_devel Aug 1, 2020
@csarofeen csarofeen deleted the revert-256-contiguity_cherry_pick branch June 9, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants