Skip to content

Change indexing of tensor factories#2248

Merged
zasdfgbnm merged 4 commits intodevelfrom
index-hoisting-factories
Dec 7, 2022
Merged

Change indexing of tensor factories#2248
zasdfgbnm merged 4 commits intodevelfrom
index-hoisting-factories

Conversation

@zasdfgbnm
Copy link
Copy Markdown
Collaborator

@zasdfgbnm zasdfgbnm commented Dec 6, 2022

Move their implementation from codegen.cpp into index_compute.cpp and lower_index.cpp, and do index hoisting on the final result.

@zasdfgbnm zasdfgbnm marked this pull request as draft December 7, 2022 00:27
@zasdfgbnm zasdfgbnm marked this pull request as ready for review December 7, 2022 00:42
@zasdfgbnm zasdfgbnm requested a review from naoyam December 7, 2022 00:43
Copy link
Copy Markdown
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zasdfgbnm zasdfgbnm merged commit ac09bae into devel Dec 7, 2022
@zasdfgbnm zasdfgbnm deleted the index-hoisting-factories branch December 7, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants