Skip to content

Change TensorIndex to store a single Val*#2234

Merged
zasdfgbnm merged 9 commits intodevelfrom
tensor-index-single-val
Dec 6, 2022
Merged

Change TensorIndex to store a single Val*#2234
zasdfgbnm merged 9 commits intodevelfrom
tensor-index-single-val

Conversation

@zasdfgbnm
Copy link
Copy Markdown
Collaborator

@zasdfgbnm zasdfgbnm commented Dec 2, 2022 •
edited
Loading

Because a single Val* is more friendly to simplify

@zasdfgbnm zasdfgbnm marked this pull request as ready for review December 2, 2022 03:43
@zasdfgbnm zasdfgbnm requested a review from naoyam December 2, 2022 03:43
zasdfgbnm
zasdfgbnm commented Dec 2, 2022
View reviewed changes
Comment thread torch/csrc/jit/codegen/cuda/lower_misaligned_vectorization.cpp
@zasdfgbnm zasdfgbnm mentioned this pull request Dec 2, 2022
Merged
naoyam
naoyam reviewed Dec 2, 2022
View reviewed changes
Comment thread torch/csrc/jit/codegen/cuda/kernel_ir.h Outdated
Comment thread torch/csrc/jit/codegen/cuda/index_compute.h Outdated
Comment thread torch/csrc/jit/codegen/cuda/lower_misaligned_vectorization.cpp
@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

zasdfgbnm commented Dec 2, 2022

I will hold the merge of this until #2235 is merged. #2235 is more important, and this PR will surely conflict with it.

naoyam
naoyam approved these changes Dec 2, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csarofeen
csarofeen approved these changes Dec 5, 2022
View reviewed changes
Copy link
Copy Markdown
Owner

@csarofeen csarofeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zasdfgbnm zasdfgbnm merged commit d258558 into devel Dec 6, 2022
@zasdfgbnm zasdfgbnm deleted the tensor-index-single-val branch December 6, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naoyam naoyam naoyam approved these changes

@csarofeen csarofeen csarofeen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zasdfgbnm @naoyam @csarofeen