cephmount: add setfacl and getfacl support #5429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
reviewed
Dec 10, 2025
glpatcern
requested changes
Dec 10, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
I think it's all fine except a few minor things.
jessegeens
reviewed
Dec 11, 2025
jessegeens
reviewed
Dec 11, 2025
jessegeens
reviewed
Dec 11, 2025
jessegeens
requested changes
Dec 11, 2025
Contributor
jessegeens
left a comment
There was a problem hiding this comment.
(put the comments in separately)
glpatcern
approved these changes
Dec 18, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
If Jesse is happy, this can be merged!
jessegeens
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adds some styling fixes (go fmt).