Skip to content

Conversation

@jessegeens
Copy link
Contributor

@jessegeens jessegeens commented Nov 21, 2025

Spaces broke proper DAV support, because returned hrefs in the PROPFIND always contained space IDs, even if these were not present in the incoming request. This is fixed now, by writing the href based in the incoming URL

@update-docs
Copy link

update-docs bot commented Nov 21, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jessegeens jessegeens force-pushed the fix/spaces-dav branch 24 times, most recently from 4ce72b7 to e8a3504 Compare November 27, 2025 14:44
@jessegeens jessegeens changed the title only respond with space ID in paths when handling spaces Bring back proper DAV support Nov 27, 2025
@glpatcern glpatcern linked an issue Nov 28, 2025 that may be closed by this pull request
@jessegeens jessegeens force-pushed the fix/spaces-dav branch 2 times, most recently from 63eee1e to e375302 Compare November 28, 2025 09:58
@jessegeens jessegeens force-pushed the fix/spaces-dav branch 13 times, most recently from 91a0776 to c25d023 Compare November 28, 2025 14:07
@jessegeens jessegeens marked this pull request as ready for review November 28, 2025 14:10
@jessegeens jessegeens force-pushed the fix/spaces-dav branch 2 times, most recently from 7920319 to 6dc7b40 Compare November 28, 2025 14:15
Copy link
Contributor

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks, just happiness

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I share the happiness ;-) but we have to see what happens with the OCM logic

@glpatcern glpatcern merged commit 8855f78 into master Nov 29, 2025
14 checks passed
@jessegeens jessegeens deleted the fix/spaces-dav branch December 11, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spaces incompatibility

4 participants