Support signed URLs #5405
Merged
Support signed URLs #5405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
9b7ce7e to
701f3af
Compare
diocas
requested changes
Nov 24, 2025
internal/http/interceptors/auth/signed_url/strategy/signed_url/signed_url.go
Outdated
Show resolved
Hide resolved
internal/http/interceptors/auth/signed_url/strategy/signed_url/signed_url.go
Outdated
Show resolved
Hide resolved
internal/http/interceptors/auth/signed_url/strategy/signed_url/signed_url.go
Show resolved
Hide resolved
internal/http/interceptors/auth/signed_url/strategy/signed_url/signed_url.go
Outdated
Show resolved
Hide resolved
internal/http/interceptors/auth/signed_url/strategy/signed_url/signed_url.go
Outdated
Show resolved
Hide resolved
internal/http/interceptors/auth/signed_url/strategy/signed_url/signed_url.go
Outdated
Show resolved
Hide resolved
internal/http/interceptors/auth/signed_url/strategy/signed_url/signed_url.go
Outdated
Show resolved
Hide resolved
internal/http/services/owncloud/ocs/handlers/cloud/user/user.go
Outdated
Show resolved
Hide resolved
b77b3bd to
1e64f1b
Compare
glpatcern
previously approved these changes
Nov 27, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
Looks good at this point, let's just cleanup the GitHub description
diocas
requested changes
Nov 28, 2025
Contributor
diocas
left a comment
There was a problem hiding this comment.
Ready to merge after this small cleanup.
internal/http/interceptors/auth/signed_url/strategy/signed_url/signed_url.go
Outdated
Show resolved
Hide resolved
18dfb32 to
755783d
Compare
755783d to
2ae343d
Compare
diocas
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works properly, though in the future it would be good to move to server-side generated signatures instead of handling this in web