feat(ocm): add wayf specific /discover and /federations endpoints to sciencemesh package #5385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4475c09 to
7e5820a
Compare
…sciencemesh package Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
7e5820a to
54ba127
Compare
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
glpatcern
reviewed
Oct 28, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
Thanks for this contribution, very good, just a couple of comments
glpatcern
reviewed
Oct 31, 2025
glpatcern
reviewed
Oct 31, 2025
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Instead of creating a client each time a function is called, create client once Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
@glpatcern recommendations moved types to spec.go used directory urls instead of a file Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
glpatcern
reviewed
Nov 5, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
As mentioned, this is all good to go to QA except for a mini fix you could do
as per @glpatcern recommendations Also return 404 if the remote EFSS doesn't provide an inviteAcceptDialog Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
glpatcern
approved these changes
Nov 7, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
Looks good, looking forward to the corresponding web frontend code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of cs3org/OCM-STA#1
Description
This PR implements WAYF (Where Are You From) specific discovery endpoints for the ScienceMesh package, enabling dynamic OCM provider discovery and federation management.
Technical
Things I've added to Reva
/sciencemesh/federationsendpoint: Lists available federations and their associated servers/sciencemesh/federationsendpoint: Enables active discovery of OCM providers and their capabilitiesInviteAcceptDialogdiscovery: Dynamically retrieves invitation handling URLs from remote providersCode changes
internal/http/services/sciencemesh/wayf.go: Core logic for federation management and provider discoveryinternal/http/services/sciencemesh/sciencemesh.go: Added new endpoints and configuration optionsinternal/http/services/wellknown/ocm.go: Changed the default path ofInviteAcceptDialogfor the new GUI chnages