Skip to content

spaces: skip spaces not available #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glpatcern merged 6 commits into from
Oct 16, 2025
Merged

spaces: skip spaces not available #5365

glpatcern merged 6 commits into from
Oct 16, 2025

Conversation

@labkode
Copy link
Member

@labkode labkode commented Oct 16, 2025 •
edited
Loading

adds new configuration option:

space_resolution_timeout = 4

@update-docs
Copy link

update-docs bot commented Oct 16, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

glpatcern
glpatcern requested changes Oct 16, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hugo, I have a question

labkode and others added 2 commits October 16, 2025 11:44
@labkode @glpatcern
Update internal/grpc/services/spacesregistry/spacesregistry.go
9a50621 
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
@labkode
do not create new ctx
8480c88
glpatcern
glpatcern approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @jessegeens please check the context change ;-)

@jessegeens
Copy link
Contributor

jessegeens commented Oct 16, 2025

I think it's fine, we're not overwriting the original context, we might just pass "too much" but that's okay

@glpatcern glpatcern merged commit ac3ab8b into cs3org:master Oct 16, 2025
14 checks passed
@labkode labkode deleted the skip-spaces branch October 17, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glpatcern glpatcern glpatcern approved these changes

@jessegeens jessegeens jessegeens approved these changes

@diocas diocas Awaiting requested review from diocas diocas is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labkode @jessegeens @glpatcern