Skip to content

OCM: include OCM shares in SharedByMe view #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glpatcern merged 5 commits into from
Nov 7, 2025
Merged

OCM: include OCM shares in SharedByMe view #5363

glpatcern merged 5 commits into from
Nov 7, 2025

Conversation

@rawe0
Copy link
Member

@rawe0 rawe0 commented Oct 14, 2025 •
edited by glpatcern
Loading

Needs to be tested once the changes to the CS3APIs have been merged, cs3org/cs3apis#255.

  • The CS3APis verison has been updated to include "ListExistingOcmShares".
  • The OCM shares are now included in the getSharedByMe call.
  • The filters have been updated to adapt to changes from the updated CS3APIs.
  • Fixed bug where only ocm users were queried if it was enabled.
  • Consolidated OCM Address resolutions in a single function, fixes Parsing of OCM Address in case of more than one "@" present #5383

@update-docs
Copy link

update-docs bot commented Oct 14, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rawe0 rawe0 force-pushed the ocm-shared-by-me branch 8 times, most recently from cf7a00f to 52333cb Compare October 16, 2025 15:56
@rawe0 rawe0 marked this pull request as ready for review October 16, 2025 15:56
glpatcern
glpatcern previously approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works in QA, we need to test with OCM disabled

@rawe0 rawe0 force-pushed the ocm-shared-by-me branch 3 times, most recently from e3cb16f to c25ceeb Compare October 20, 2025 08:01
glpatcern
glpatcern reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some preliminary comments, and for now let's ignore the CI - apparently docker is suffering some outages because of a cascade effect

@rawe0 rawe0 force-pushed the ocm-shared-by-me branch 2 times, most recently from 8a565a7 to fae9993 Compare October 21, 2025 09:55
@jessegeens jessegeens force-pushed the ocm-shared-by-me branch 5 times, most recently from 8a244d9 to 8a9fac8 Compare October 21, 2025 12:05
@rawe0 rawe0 force-pushed the ocm-shared-by-me branch 3 times, most recently from abca225 to e723951 Compare October 21, 2025 13:10
@glpatcern glpatcern force-pushed the ocm-shared-by-me branch 9 times, most recently from b468257 to 8f38c10 Compare October 28, 2025 07:23
@glpatcern glpatcern mentioned this pull request Oct 28, 2025
Closed
@glpatcern glpatcern force-pushed the ocm-shared-by-me branch 3 times, most recently from 7f40a75 to 5acc911 Compare October 28, 2025 16:59
@glpatcern glpatcern self-requested a review November 6, 2025 15:37
@glpatcern glpatcern marked this pull request as ready for review November 7, 2025 08:51
glpatcern
glpatcern previously approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now works entirely

@glpatcern glpatcern self-requested a review November 7, 2025 08:59
@glpatcern glpatcern merged commit bb85bb1 into master Nov 7, 2025
26 of 27 checks passed
@jessegeens jessegeens deleted the ocm-shared-by-me branch December 11, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glpatcern glpatcern glpatcern approved these changes

@diocas diocas Awaiting requested review from diocas diocas is a code owner

@jessegeens jessegeens Awaiting requested review from jessegeens jessegeens is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parsing of OCM Address in case of more than one "@" present

4 participants

@rawe0 @glpatcern @jessegeens