Skip to content

Fix OCM legacy access #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glpatcern merged 11 commits into from
Oct 16, 2025
Merged

Fix OCM legacy access #5338

glpatcern merged 11 commits into from
Oct 16, 2025

Conversation

@glpatcern
Copy link
Member

@glpatcern glpatcern commented Oct 1, 2025 •
edited
Loading

  • Added logging
  • Added tests to validate that access works in both legacy modes
  • Fixed OCM DAV access
  • Fixed response status code on /ocm/shares
  • Do not resolve remote OCM users from the local user provider
  • Do a PROPFIND on remote legacy shares to set their type (file vs folder) correctly

@update-docs
Copy link

update-docs bot commented Oct 1, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@glpatcern glpatcern marked this pull request as draft October 1, 2025 15:36
@glpatcern glpatcern changed the title WIP: fix ocm access WIP: fix OCM legacy access Oct 1, 2025
@glpatcern glpatcern force-pushed the fix-ocm-access branch 15 times, most recently from 8c1f0c7 to 8e9eba4 Compare October 8, 2025 07:25
@glpatcern glpatcern changed the title WIP: fix OCM legacy access Fix OCM legacy access Oct 9, 2025
@glpatcern glpatcern force-pushed the fix-ocm-access branch 9 times, most recently from afb387f to d576c11 Compare October 12, 2025 14:37
@glpatcern glpatcern marked this pull request as ready for review October 15, 2025 08:37
rawe0
rawe0 reviewed Oct 15, 2025
View reviewed changes
Copy link
Member

@rawe0 rawe0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, if it hasn't been tested CERNBox -> CERNBox I would like to do that though.

rawe0
rawe0 previously approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@rawe0 rawe0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested remote access CERNBox -> CERNBox and everything seems fine.

jessegeens
jessegeens reviewed Oct 15, 2025
View reviewed changes
jessegeens
jessegeens previously approved these changes Oct 15, 2025
View reviewed changes
@glpatcern glpatcern dismissed stale reviews from jessegeens and rawe0 via bff4796 October 15, 2025 15:34
@glpatcern glpatcern force-pushed the fix-ocm-access branch 2 times, most recently from bff4796 to b938f43 Compare October 15, 2025 15:43
@glpatcern glpatcern force-pushed the fix-ocm-access branch 2 times, most recently from a3a8e11 to 135dd85 Compare October 16, 2025 08:14
jessegeens
jessegeens reviewed Oct 16, 2025
View reviewed changes
jessegeens
jessegeens previously approved these changes Oct 16, 2025
View reviewed changes
@glpatcern glpatcern merged commit 0e95942 into master Oct 16, 2025
22 checks passed
@jessegeens jessegeens deleted the fix-ocm-access branch December 11, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessegeens jessegeens jessegeens left review comments

@rawe0 rawe0 rawe0 left review comments

@diocas diocas Awaiting requested review from diocas diocas is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@glpatcern @jessegeens @rawe0