-
Notifications
You must be signed in to change notification settings - Fork 123
OCM: Update, Delete and Show OCM Shares in SharedWith View #5320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1c766d to
f999e55
Compare
Contributor
|
I guess this one depends on #5316 ? |
f999e55 to
9816e1e
Compare
Member
Author
In fact they're kind of separate now that I think of it but it makes sense to merge them in this order I think |
3a31ed6 to
a977dd1
Compare
a977dd1 to
c2f4eae
Compare
jessegeens
reviewed
Sep 19, 2025
jessegeens
reviewed
Sep 19, 2025
Contributor
|
Looks ok! |
c17c304 to
d6c9447
Compare
d6c9447 to
f406fa8
Compare
glpatcern
previously approved these changes
Sep 23, 2025
glpatcern
previously approved these changes
Sep 23, 2025
glpatcern
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for displaying OCM shares in the SharedWith view when a file is selected. It also enables updating the permissions of those shares and deleting OCM shares.
Additionally it fixes the advertised URL for the ScienceMesh frontend app to reflect the new upstream one.