Skip to content

Conversation

@rawe0
Copy link
Member

@rawe0 rawe0 commented Sep 18, 2025

This PR adds support for displaying OCM shares in the SharedWith view when a file is selected. It also enables updating the permissions of those shares and deleting OCM shares.

Additionally it fixes the advertised URL for the ScienceMesh frontend app to reflect the new upstream one.

@rawe0 rawe0 changed the title OCM: Update, Delete and Show OCM in SharedWith OCM: Update, Delete and Show OCM Shares in SharedWith Sep 18, 2025
@rawe0 rawe0 force-pushed the ocm-fixes-permissions branch from d1c766d to f999e55 Compare September 18, 2025 09:23
@rawe0 rawe0 changed the title OCM: Update, Delete and Show OCM Shares in SharedWith OCM: Update, Delete and Show OCM Shares in SharedWith View Sep 18, 2025
@jessegeens
Copy link
Contributor

I guess this one depends on #5316 ?

@rawe0 rawe0 force-pushed the ocm-fixes-permissions branch from f999e55 to 9816e1e Compare September 18, 2025 09:36
@rawe0
Copy link
Member Author

rawe0 commented Sep 18, 2025

I guess this one depends on #5316 ?

In fact they're kind of separate now that I think of it but it makes sense to merge them in this order I think

@rawe0 rawe0 force-pushed the ocm-fixes-permissions branch 2 times, most recently from 3a31ed6 to a977dd1 Compare September 19, 2025 12:15
@rawe0 rawe0 force-pushed the ocm-fixes-permissions branch from a977dd1 to c2f4eae Compare September 19, 2025 13:12
@jessegeens
Copy link
Contributor

Looks ok!
One general comment though: I think drive_permissions is becoming quite large now... maybe we can split it up into a few different files?

@rawe0 rawe0 force-pushed the ocm-fixes-permissions branch 10 times, most recently from c17c304 to d6c9447 Compare September 22, 2025 14:03
@rawe0 rawe0 force-pushed the ocm-fixes-permissions branch from d6c9447 to f406fa8 Compare September 23, 2025 08:03
glpatcern
glpatcern previously approved these changes Sep 23, 2025
glpatcern
glpatcern previously approved these changes Sep 23, 2025
@glpatcern glpatcern self-requested a review September 24, 2025 13:22
@glpatcern glpatcern merged commit d1bcea5 into master Sep 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants