Skip to content

Conversation

@jessegeens
Copy link
Contributor

@jessegeens jessegeens commented Sep 3, 2025

  • Set SkipFetchingGroupMembers and SkipFetchingUserGroups to true in libregraph API; we don't need those there and fetching group members of cern-all-users crashes the daemon
  • Better nil handling
  • Move some conversion methods from shares.go to conversions.go

@update-docs
Copy link

update-docs bot commented Sep 3, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jessegeens jessegeens force-pushed the fix/spaces-shares branch 3 times, most recently from 9b93267 to faf51c9 Compare September 3, 2025 15:03
@jessegeens jessegeens changed the title [WIP] fix spaces shares Fix nilpointers in spaces shares Sep 3, 2025
@jessegeens jessegeens marked this pull request as ready for review September 3, 2025 15:03
diocas
diocas previously approved these changes Sep 3, 2025
Copy link
Contributor

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start splitting fixes and cleanups into separate PRs. But I'm still approving.

@diocas diocas merged commit 7dc9f10 into master Sep 3, 2025
15 checks passed
@diocas diocas deleted the fix/spaces-shares branch September 3, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants