Skip to content

OCM: Fixes to enable OCM sharing in the LibreGraph implementation #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glpatcern merged 9 commits into from
Sep 8, 2025
Merged

OCM: Fixes to enable OCM sharing in the LibreGraph implementation #5286

glpatcern merged 9 commits into from
Sep 8, 2025

Conversation

@rawe0
Copy link
Member

@rawe0 rawe0 commented Sep 1, 2025 •
edited
Loading

This enables for creation of OCM shares through the LibreGraph implementation instead of using the old /sciencemesh endpoint that is gone in the new frontend.

  • LinkOrShare has been changed to include OCMShares and renamed
  • Web app now sends a POST request instead of a GET for OCM invite generation - this has been reflected in the backend.
  • Adds the IDP to the user id when returned if user is of type federated.
  • Cleaned up dead code since the /sciencemesh/create-share is no longer used.
  • Conversions now take OCM shares into account as well.

Note: Frontend needs to be updated to include a RecipientType 'Remote' if user is federated.

@update-docs
Copy link

update-docs bot commented Sep 1, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rawe0 rawe0 force-pushed the ocm-fixes branch 2 times, most recently from 2d5cb99 to b38807d Compare September 1, 2025 12:20
glpatcern
glpatcern requested changes Sep 2, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are mostly cosmetic changes, as far as I can see the refactored logic for normal shares should still work

@rawe0 rawe0 requested a review from glpatcern September 2, 2025 11:55
@rawe0 rawe0 force-pushed the ocm-fixes branch 2 times, most recently from 6679108 to 4f9056a Compare September 7, 2025 20:39
glpatcern
glpatcern reviewed Sep 8, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of trivial changes for clarity, otherwise we can merge and QA this

rawe0 and others added 2 commits September 8, 2025 09:45
@rawe0 @glpatcern
Update internal/http/services/owncloud/ocgraph/shares.go
a42daae 
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
@rawe0 @glpatcern
Update internal/http/services/owncloud/ocgraph/conversions.go
fed6f9d 
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
@glpatcern glpatcern self-requested a review September 8, 2025 08:08
@glpatcern glpatcern merged commit 8301819 into master Sep 8, 2025
26 checks passed
@jessegeens jessegeens deleted the ocm-fixes branch December 11, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glpatcern glpatcern glpatcern approved these changes

@diocas diocas Awaiting requested review from diocas diocas is a code owner

@jessegeens jessegeens Awaiting requested review from jessegeens jessegeens is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rawe0 @glpatcern