eos: fixed use of "app" tag #5130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
852205d to
69719a1
Compare
154affc to
3024b1a
Compare
Member
Author
|
Tests were completed and I got the proof that we're doing "the right thing", i.e. the necessary header is passed to EOS. Then we have a bug in EOS to be fixed for this to really work end-to-end, but I believe we can merge this PR in Reva anyway. |
diocas
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the use of the
eos.appquery parameter (for xrootd) or header (for HTTP traffic) is reviewed and "cleaned up"::as this is used as separator in case of lockshttp/as nowadays EOS is overriding the app tag withhttp/in front for any traffic that comes via HTTP. As Reva is an HTTP client, we enforce it in all cases (even when it's used via xrootd)The latter point is important to make sure lock enforcing works correctly, when the app actually reflects a web app for which a file was locked.
Side note: the
eos.appparameter has been overloaded to serve two purposes in EOS, that is traffic tagging for monitoring purposes and file locking by apps. This was a sub-optimal design choice, and it implies that we have to fiddle with the extrahttp/prefix...