eosfs: use external script for home creation + drop support for shadow namespace #4984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namespace and related code
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jessegeens
reviewed
Dec 3, 2024
jessegeens
approved these changes
Dec 3, 2024
diocas
reviewed
Dec 3, 2024
Contributor
diocas
left a comment
There was a problem hiding this comment.
What was the reason for the shadow ns? Maybe it's worth to explain in the PR why it's ok to remove it.
Member
Author
I actually put that in a ADR. Hugo just confirmed this is a legacy attempt to implement the "share jail", but it has never been used. |
diocas
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes as part of the effort to operate EOS without being root, see #4977
In this PR the post-home creation hook (and corresponding flag) is replaced by a
create_home_hook, and the following configuration parameters are suppressed:shadow_namespaceshare_folderdefault_quota_bytesdefault_secondary_quota_bytesdefault_quota_filesuploads_namespace(unused)