Add Path#relative?#16473
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Dec 9, 2025
Merged
Conversation
straight-shoota
approved these changes
Dec 3, 2025
Contributor
|
Windows has drive-relative, root-relative, and pure relative paths, so "absolute" and "relative" are not a dichotomy for |
Contributor
Author
|
IIUC Windows is an outlier here, on any other system this distinction is pretty clear... 🤷♂️ |
Member
|
IMO the term "relative" is unambiguous. It refers to on-absolute paths on both POSIX and Windows. Drive-relative and root-relative paths on Windows are explicitly called relative, so it makes sense that they're subsumed in |
ysbaddaden
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Akin to
URI#relative?, opposite ofPath#absolute?.